Transpose bug #7170
Merged
Transpose bug #7170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnc1231
force-pushed
the
johnc-transpose-bug
branch
from
6758b22
to
d8262e9
Compare
patrick-schultz
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockMatrix.transposewas not implemented correctly, failed on sparse, rectangular matrices.Specifically, the
transposeBIfunction in the old implementation was a function from new block indices to old block indices. However, in mapping over maybeBlocks, it was used as though it was a function from old block indices to new block indices. To fix this, I now havetransposeBIandinverseTransposeBI