Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transpose bug #7170

Merged
merged 3 commits into from Oct 1, 2019
Merged

Transpose bug #7170

merged 3 commits into from Oct 1, 2019

Conversation

johnc1231
Copy link
Contributor

@johnc1231 johnc1231 commented Oct 1, 2019

BlockMatrix.transpose was not implemented correctly, failed on sparse, rectangular matrices.

Specifically, the transposeBI function in the old implementation was a function from new block indices to old block indices. However, in mapping over maybeBlocks, it was used as though it was a function from old block indices to new block indices. To fix this, I now have transposeBI and inverseTransposeBI

@johnc1231 johnc1231 changed the title Transpose bug [wip] Transpose bug Oct 1, 2019
@johnc1231 johnc1231 changed the title [wip] Transpose bug Transpose bug Oct 1, 2019
@danking danking merged commit 1fa71bd into hail-is:master Oct 1, 2019
1 check passed
@johnc1231 johnc1231 deleted the johnc-transpose-bug branch Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants