[hail][bugfix]: fix out of bounds read in LoadVCF #7182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading flag fields, we attempt to check if `line(pos) == '='`. When a flag occurs at end of line, pos will be equal to line.length, and thus caused an out of bounds read on the string. Added the bounds check to prevent this.
|
I have confirmed that the test I added fails with the same error laurent saw in the linked conversation, and passes with the change. |
tpoterba
previously requested changes
Oct 3, 2019
| @@ -914,7 +914,7 @@ final class VCFLine(val line: String, arrayElementsRequired: Boolean) { | |||
| if (infoType.hasField(key)) { | |||
| rvb.setFieldIndex(infoType.fieldIdx(key)) | |||
| if (infoFlagFieldNames.contains(key)) { | |||
| if (line(pos) == '=') { | |||
| if (pos != line.length && line(pos) == '=') { | |||
There was a problem hiding this comment.
should be !(endField(pos) I think?
There was a problem hiding this comment.
endField and pos != line.length are about as clear in my mind, and the second won't check needlessly for the presence of a tab.
chrisvittal
dismissed
tpoterba’s stale review
Pushing back. Think the change is fine as is.
tpoterba
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading flag fields, we attempt to check if
line(pos) == '='.When a flag occurs at end of line, pos will be equal to line.length,
and thus caused an out of bounds read on the string.
Added the bounds check to prevent this.