Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hailctl] Fix cluster creation #7185

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@tpoterba
Copy link
Collaborator

commented Oct 3, 2019

Python is terrible.

Python is terrible.
'jgscm<0.2',
'jupyter', 'tornado<6', # https://github.com/hail-is/hail/issues/5505

This comment has been minimized.

Copy link
@akotlar

akotlar Oct 3, 2019

Collaborator

lets pin the jupyter version

This comment has been minimized.

Copy link
@tpoterba

tpoterba Oct 3, 2019

Author Collaborator

we can't :/ Jupyter basically uses shim versions

This comment has been minimized.

Copy link
@akotlar

akotlar Oct 3, 2019

Collaborator

I can accept, not sure if you want dan to look

@tpoterba tpoterba dismissed akotlar’s stale review Oct 3, 2019

cant pin

Copy link
Collaborator

left a comment

looks good

'jgscm<0.2',
'jupyter', 'tornado<6', # https://github.com/hail-is/hail/issues/5505

This comment has been minimized.

Copy link
@akotlar

akotlar Oct 3, 2019

Collaborator

I can accept, not sure if you want dan to look

@tpoterba

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 3, 2019

🤷‍♂ he saw at office hours

@akotlar

This comment has been minimized.

Copy link
Collaborator

commented Oct 3, 2019

He's busy, I'll accept

@akotlar
akotlar approved these changes Oct 3, 2019
@danking danking merged commit 72c70a2 into hail-is:master Oct 3, 2019
1 check passed
1 check passed
ci-test success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.