New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hail] [streams] more complicated streams #7229
Conversation
7d35043
to
5e6db04
Compare
nice work, Milo! |
This is really great. I'm excited to get it merged and start using it!
A few questions and requests while I finish working through it:
hail/src/main/scala/is/hail/asm4s/joinpoint/ParameterPack.scala
Outdated
Show resolved
Hide resolved
hail/src/main/scala/is/hail/asm4s/joinpoint/ParameterPack.scala
Outdated
Show resolved
Hide resolved
This isn't WIP anymore, is it? Also, do you just want to delete the first stream PR? It's gotten a bit out of sync with the changes in this one. If you're happy with this, I'm ready to approve. |
What do we need to do to get this in? |
standalone emitstream missing impl make NA case trivially easy simplify range impl
fix the Let test
add Skip other streams add tests delete all but map/filter delete tests
simplify makeArray implementation
delete Empty; rename dummyState => emptyState get rid of Empty in toArrayIterator dummyState to emptyState in missing/range get rid of Empty in test suite delete Empty in map, filter rename dummyState in make
leftjoin test clean up compose impl less code dup in EmitStream.compose by doing Skip(..dummyState..) flatmap new emptyState version
leftjoin new emptyState version
get rid of Empty in compose get rid of empty in compose (2)
get rid of Empty in leftjoin
add all but map/filter add tests more complex let test ...more get rid of Empty in scan
avoid calling the continuation too many times in EmitStream.sequence avoid calling the Missing continuation in guardParam
just rebased and fixed something. should be ready to merge after it passes CI |
|
Stacked on #7228
(transitively, #7207)Implements the following pull based streams:
ArrayFlatMap
ArrayLeftJoinDistinct
ArrayScan
ArrayAggScan