[hail] [streams] more complicated streams #7229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iitalics
force-pushed
the
jvm-streams
branch
2 times, most recently
from
7d35043
to
5e6db04
Compare
|
nice work, Milo! |
patrick-schultz
requested changes
Oct 29, 2019
This is really great. I'm excited to get it merged and start using it!
A few questions and requests while I finish working through it:
hail/src/main/scala/is/hail/asm4s/joinpoint/ParameterPack.scala
Outdated
Show resolved
Hide resolved
hail/src/main/scala/is/hail/asm4s/joinpoint/ParameterPack.scala
Outdated
Show resolved
Hide resolved
patrick-schultz
previously requested changes
Oct 30, 2019
|
This isn't WIP anymore, is it? Also, do you just want to delete the first stream PR? It's gotten a bit out of sync with the changes in this one. If you're happy with this, I'm ready to approve. |
iitalics
added
infrastructure
|
What do we need to do to get this in? |
standalone emitstream missing impl make NA case trivially easy simplify range impl
fix the Let test
add Skip other streams add tests delete all but map/filter delete tests
simplify makeArray implementation
delete Empty; rename dummyState => emptyState get rid of Empty in toArrayIterator dummyState to emptyState in missing/range get rid of Empty in test suite delete Empty in map, filter rename dummyState in make
leftjoin test clean up compose impl less code dup in EmitStream.compose by doing Skip(..dummyState..) flatmap new emptyState version
leftjoin new emptyState version
get rid of Empty in compose get rid of empty in compose (2)
get rid of Empty in leftjoin
add all but map/filter add tests more complex let test ...more get rid of Empty in scan
avoid calling the continuation too many times in EmitStream.sequence avoid calling the Missing continuation in guardParam
|
just rebased and fixed something. should be ready to merge after it passes CI |
patrick-schultz
approved these changes
Dec 5, 2019
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Stacked on #7228
(transitively, #7207)Implements the following pull based streams:
ArrayFlatMapArrayLeftJoinDistinctArrayScanArrayAggScan