Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] Interactive widget for Table/MatrixTable describe #7240

Merged
merged 5 commits into from Oct 10, 2019

Conversation

tpoterba
Copy link
Contributor

@tpoterba tpoterba commented Oct 9, 2019

No description provided.

@tpoterba
Copy link
Contributor Author

tpoterba commented Oct 9, 2019

image

@akotlar
Copy link
Contributor

akotlar commented Oct 10, 2019

Really cool, nice work!

@akotlar
Copy link
Contributor

akotlar commented Oct 10, 2019

Why is the entirety of table.scala diff?

@tpoterba
Copy link
Contributor Author

wtf...

@tpoterba
Copy link
Contributor Author

Is this a git bug?

$ cp src/main/scala/is/hail/table/Table.scala /tmp/table1.scala
$ gco interactive-describe-2
Switched to branch 'interactive-describe-2'
Your branch is up to date with 'origin/interactive-describe-2'.
$ cp src/main/scala/is/hail/table/Table.scala /tmp/table2.scala
$ diff /tmp/table1.scala /tmp/table2.scala

@akotlar
Copy link
Contributor

akotlar commented Oct 10, 2019

On mobile, but could be mode change?

Edit: Actually I think those appear as permissions changes. Hm

@tpoterba
Copy link
Contributor Author

they have the same md5 as well.

@tpoterba
Copy link
Contributor Author

OH! this is a file in the OLD src root.

@tpoterba
Copy link
Contributor Author

(shame on me for suspecting a git bug)

@akotlar
Copy link
Contributor

akotlar commented Oct 10, 2019

OH! this is a file in the OLD src root.

Linus is never wrong

@akotlar
Copy link
Contributor

akotlar commented Oct 10, 2019

I’ve seen this/used it, so happy to approve, if you want to assign me.

@tpoterba
Copy link
Contributor Author

yes, sure. I'll ask Kumar for more feedback tomorrow.

@tpoterba tpoterba assigned tpoterba and akotlar and unassigned tpoterba Oct 10, 2019
@danking danking merged commit ea058bd into hail-is:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants