[hail] add html output for summarize#7280
Merged
danking merged 7 commits intohail-is:masterfrom Oct 13, 2019
Merged
Conversation
* change types representation * fix explode numbers * don't cache for now
tpoterba
approved these changes
Oct 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ended up restructuring the summarizing to make the formatting easier.
I also ended up putting the summary stuff on the expression; the vague goal is to allow a call to
table.summarize()to cache all the summaries of the (nested) row fields, so that subsequent calls to e.g.table.locus.summarize()should be free.