Merged
Conversation
patrick-schultz
previously requested changes
Oct 21, 2019
Comment on lines
+301
to
+308
| Examples | ||
| -------- | ||
| Estimate the median of the `HT` field. | ||
|
|
||
| >>> table1.aggregate(hl.agg.approx_median(table1.HT)) # doctest: +SKIP_OUTPUT_CHECK | ||
| 64 |
Member
There was a problem hiding this comment.
In cases like this, it seems valuable to me to actually document the implementation, to help people discover and learn the more general operations.
Contributor
Author
There was a problem hiding this comment.
Good call 👍 I'll mention this is just a wrapper on approx_quantiles. Also, forgot to copy the documentation of what k does.
johnc1231
force-pushed
the
johnc-approx-median
branch
from
39482a1 to
02015d0
Compare
patrick-schultz
approved these changes
Oct 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just an alias for
approx_quantiles(.5)but easier to find when searching for median and probably a very common operation.