Skip to content

[hail] Improve performance of IR copying #7355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 22, 2019
Merged

[hail] Improve performance of IR copying #7355

merged 4 commits into from
Oct 22, 2019

Conversation

tpoterba
Copy link
Contributor

  • don't use inefficient unapply
  • Cache the returnType of AggSignatures so they persist through copies
                           Name      Ratio    Time 1    Time 2
                           ----      -----    ------    ------
table_big_aggregate_compilation      85.6%     4.113     3.519
----------------------
Geometric mean: 85.6%
Simple mean: 85.6%
Median:  85.6%

@tpoterba
[hail] Improve performance of IR copying
072ed6b 
 * don't use inefficient unapply
 * Cache the returnType of AggSignatures so they persist through copies

```
                           Name      Ratio    Time 1    Time 2
                           ----      -----    ------    ------
table_big_aggregate_compilation      85.6%     4.113     3.519
----------------------
Geometric mean: 85.6%
Simple mean: 85.6%
Median:  85.6%
```
@tpoterba
Copy link
Contributor Author

Prune and ForwardLets probably need to be adjusted to allow no-copy passes if nothing changes.

@iitalics
Copy link
Contributor

doesnt NDArrayShape need an assert?

@tpoterba
Copy link
Contributor Author

added asserts.

@danking danking merged commit 8230b3f into hail-is:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iitalics iitalics iitalics approved these changes

Assignees

@iitalics iitalics

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tpoterba @iitalics @danking