Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[hail] add delimiter argument to import_matrix_table #7379
Conversation
This parameter is a deprecated name for `delimiter`, please use that | ||
instead. | ||
delimiter : :obj:`str` | ||
A single character string which separates values in the file. | ||
Returns | ||
------- |
This comment has been minimized.
This comment has been minimized.
jigold
Oct 25, 2019
Collaborator
I was expecting to see something like this:
assert one of sep and delimiter is defined, but not both
use value from whichever is defined
This comment has been minimized.
This comment has been minimized.
danking
Oct 25, 2019
Author
Collaborator
Wow good point, I must've been falling asleep when I wrote this. Fixed.
This comment has been minimized.
This comment has been minimized.
;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
danking commentedOct 25, 2019
Also note that
sep
is a deprecated name.