Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] add delimiter argument to import_matrix_table #7379

Merged
merged 4 commits into from Oct 25, 2019

Conversation

@danking
Copy link
Collaborator

danking commented Oct 25, 2019

Also note that sep is a deprecated name.

fix
This parameter is a deprecated name for `delimiter`, please use that
instead.
delimiter : :obj:`str`
A single character string which separates values in the file.
Returns
-------

This comment has been minimized.

Copy link
@jigold

jigold Oct 25, 2019

Collaborator

I was expecting to see something like this:

assert one of sep and delimiter is defined, but not both
use value from whichever is defined

This comment has been minimized.

Copy link
@danking

danking Oct 25, 2019

Author Collaborator

Wow good point, I must've been falling asleep when I wrote this. Fixed.

This comment has been minimized.

Copy link
@jigold

jigold Oct 25, 2019

Collaborator

Do we need tests for this?

fix
;
@jigold
jigold approved these changes Oct 25, 2019
@danking danking merged commit acfcd01 into hail-is:master Oct 25, 2019
1 check passed
1 check passed
ci-test success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.