Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] add delimiter argument to import_matrix_table #7379

Merged
merged 4 commits into from Oct 25, 2019

Conversation

danking
Copy link
Collaborator

@danking danking commented Oct 25, 2019

Also note that sep is a deprecated name.

jigold
jigold previously requested changes Oct 25, 2019
This parameter is a deprecated name for `delimiter`, please use that
instead.
delimiter : :obj:`str`
A single character string which separates values in the file.
Returns
-------
Copy link
Collaborator

@jigold jigold Oct 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting to see something like this:

assert one of sep and delimiter is defined, but not both
use value from whichever is defined

Copy link
Collaborator Author

@danking danking Oct 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow good point, I must've been falling asleep when I wrote this. Fixed.

Copy link
Collaborator

@jigold jigold Oct 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need tests for this?

jigold
jigold approved these changes Oct 25, 2019
@danking danking merged commit acfcd01 into hail-is:master Oct 25, 2019
1 check passed
@danking danking deleted the import-matrix-table-ergonomics branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants