Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[hail] table tail #7386
Conversation
fix python documentation for Table.tail
implement getTailPartitionCounts tentative: computeSubsetRange returns Option refactor head PCs/tail PCs into new module fix other uses of getHeadPartitionCounts fix: remove 'private'
fixup: PrunDeadFields entry for TableTail
fixup RVD.tail
testIncrementalPCSubset
This comment has been minimized.
This comment has been minimized.
can you add a python test that does something to the effect of:
|
This comment has been minimized.
This comment has been minimized.
FYI, the PR shows up in my scorecard.hail.is queue if I'm an assignee. |
This looks awesome, a couple small comments. I think there's an obvious extension here to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
iitalics commentedOct 25, 2019
•
edited
closes #7357
.tail
function on tables:refactored some of the logic in
TableHead
, because a lot of the behavior is the samespecifically, moved some partition-counts calculations to
is.hail.utils.PartitionCounts