Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail][bugfix] Resolve handling of bindings in Matrix lowering of aggs #7402

Merged
merged 4 commits into from Nov 4, 2019

Conversation

@tpoterba
Copy link
Collaborator

tpoterba commented Oct 29, 2019

Unblocks linear regression aggregator.

Unblocks linear regression aggregator.
grouped=hl.agg.group_by(mt.e1 % 5, hl.agg.sum(mt.e1) + common_ref))
mt.cols()._force_count()

@pytest.mark.skip("does not pass due to CSE bug")

This comment has been minimized.

Copy link
@patrick-schultz

patrick-schultz Oct 30, 2019

Collaborator

What's this? Did you find a bug in the CSE?

This comment has been minimized.

Copy link
@tpoterba

tpoterba Oct 30, 2019

Author Collaborator

Yeah, looks like if there's a shared ref in an agg/scan/eval context, it should be getting duplicated for each context but it's not

This comment has been minimized.

Copy link
@patrick-schultz

patrick-schultz Oct 31, 2019

Collaborator

I have a fix ready to go. I'll PR it after this merges.

tpoterba added 3 commits Oct 31, 2019
@danking danking merged commit 14dfade into hail-is:master Nov 4, 2019
1 check passed
1 check passed
ci-test success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.