-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hail] variation of hl.float
/hl.int
that returns null on invalid string
#7453
Conversation
bd431e8
to
b8cb01d
Compare
b8cb01d
to
8be0cf8
Compare
case _ => true | ||
} | ||
|
||
def isValidFloat64(s: String): Boolean = parseSpecialNum(s) match { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're parsing twice here -- once for the check and once for the parse. That's not ideal, but I do see the reason why it's not easy to do it just once in generated code without boxing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah :I if we could catch exceptions in asm4s then that would be one nicer way to handle this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, need to add to functions rst files
(search for |
what the hell, bytecode verify errors from using locals? i saw another code-function creating locals so i assumed it was safe to do so, but apparently it isn't. |
I extremely like this. Eventually, I'd like to be able to write the table reading code in Python. That |
fixes #7408
stacked on #7452adds new toplevel hail functions:
parse_float
,parse_float32
,parse_float64
parse_int
,parse_int32
,parse_int64
all of the above accept only
tstr
expressions, and return missing for invalid numbers.