Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded if_else, deprecated cond #7467
Conversation
This comment has been minimized.
This comment has been minimized.
|
cc @tpoterba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
johnc1231 commentedNov 6, 2019
Done in the service of #6070. Should probably close that issue if this goes in and create a new issue like "delete deprecated functions" where we maintain a list of them.
I think in general if we are renaming stuff we should make a point to add the new name as soon as possible and deprecate the old thing to minimize the pain of transitioning to eventual 0.3.