Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generates docs for ndarrays #7688

Merged
merged 11 commits into from Dec 12, 2019
Merged

Generates docs for ndarrays #7688

merged 11 commits into from Dec 12, 2019

Conversation

@johnc1231
Copy link
Contributor

johnc1231 commented Dec 9, 2019

This PR generates documentation for all current ndarray functionality. Wondering if to coincide with this we should also remove the _ from hl._nd. I mostly had it there so people wouldn't poke at undocumented functionality, but this seems to work ok now.

Resolves #7531

self.save(temp_file)
return np.load(temp_file)
# @typecheck_method(axis=nullable(oneof(int, sequenceof(int))))
# def sum(self, axis=None):

This comment has been minimized.

Copy link
@patrick-schultz

This comment has been minimized.

Copy link
@johnc1231

johnc1231 Dec 10, 2019

Author Contributor

Not currently implemented, so I don't want it to show up on the NDArrayExpression class.

This comment has been minimized.

Copy link
@johnc1231

johnc1231 Dec 10, 2019

Author Contributor

I have not implemented NDArrayAgg IR Node

This comment has been minimized.

Copy link
@patrick-schultz

patrick-schultz Dec 10, 2019

Collaborator

Ah. Having a big block of commented out code is confusing. Could you save this in a branch and add it back when NDArrayAgg is implemented? Either that, or uncomment it, and have throw a "not implemented" error.

>>> hl._nd.zeros((5, 7), dtype=hl.tfloat32)
Parameters
----------
shape : `tuple` or `TupleExpression`
shape: `tuple` or :class:`.TupleExpression`

This comment has been minimized.

Copy link
@patrick-schultz

patrick-schultz Dec 10, 2019

Collaborator

space before :

@johnc1231 johnc1231 dismissed patrick-schultz’s stale review Dec 11, 2019

Thanks, made the changes.

@danking danking merged commit 8200b5b into hail-is:master Dec 12, 2019
1 check passed
1 check passed
ci-test success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.