-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generates docs for ndarrays #7688
Conversation
… out methods that have unimplemented IR nodes
self.save(temp_file) | ||
return np.load(temp_file) | ||
# @typecheck_method(axis=nullable(oneof(int, sequenceof(int)))) | ||
# def sum(self, axis=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not currently implemented, so I don't want it to show up on the NDArrayExpression
class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not implemented NDArrayAgg
IR Node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. Having a big block of commented out code is confusing. Could you save this in a branch and add it back when NDArrayAgg
is implemented? Either that, or uncomment it, and have throw a "not implemented" error.
hail/python/hail/nd/nd.py
Outdated
|
||
>>> hl._nd.zeros((5, 7), dtype=hl.tfloat32) | ||
|
||
|
||
Parameters | ||
---------- | ||
shape : `tuple` or `TupleExpression` | ||
shape: `tuple` or :class:`.TupleExpression` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space before :
Thanks, made the changes.
This PR generates documentation for all current ndarray functionality. Wondering if to coincide with this we should also remove the
_
fromhl._nd
. I mostly had it there so people wouldn't poke at undocumented functionality, but this seems to work ok now.Resolves #7531