Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] fix semantic version ordering #7732

Merged
merged 2 commits into from Dec 16, 2019
Merged

Conversation

tpoterba
Copy link
Collaborator

@tpoterba tpoterba commented Dec 14, 2019

No description provided.

@johnc1231
Copy link
Contributor

@johnc1231 johnc1231 commented Dec 14, 2019

Needs a bump, failed to pull 1kg data

streamIR: IR,
inputTypes: Seq[PType]
)(call: (F, Region, A) => Long): A => IndexedSeq[Any] = {
)(call: (F, Region, AA) => Long): AA => IndexedSeq[Any] = {
Copy link
Contributor

@johnc1231 johnc1231 Dec 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change the As to AAs?

Copy link
Collaborator Author

@tpoterba tpoterba Dec 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! Was getting a compilation warning=>error, will revert.

@danking danking merged commit af061f0 into hail-is:master Dec 16, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants