Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] method-wrap value of Let if it's potentially large #7740

Merged
merged 1 commit into from Dec 17, 2019

Conversation

@catoverdrive
Copy link
Collaborator

catoverdrive commented Dec 16, 2019

This helps with method size if we're doing a lot of

Let("foo", <value>,
    Let("bar", <value2>,
        … ))

where the size of the code generated by the values are potentially quite large. (I think doing this will unblock one of @konradjk's pipelines for now.)

@danking danking merged commit 57114c6 into hail-is:master Dec 17, 2019
1 check passed
1 check passed
ci-test success
Details
johnc1231 added a commit to johnc1231/hail that referenced this pull request Dec 17, 2019
danking added a commit that referenced this pull request Dec 17, 2019
* Created change log for 0.2.29, updated patch number

* No 7731

* Better explanation for 7732

* Added 7653, the ld_prune fix

* Addressed Tim's comments

* Added #7740

* Added the period and the line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.