[hail] method-wrap value of Let if it's potentially large #7740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-schultz
approved these changes
Dec 17, 2019
johnc1231
added a commit
to johnc1231/hail
that referenced
this pull request
Dec 17, 2019
danking
pushed a commit
that referenced
this pull request
Dec 17, 2019
* Created change log for 0.2.29, updated patch number * No 7731 * Better explanation for 7732 * Added 7653, the ld_prune fix * Addressed Tim's comments * Added #7740 * Added the period and the line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with method size if we're doing a lot of
where the size of the code generated by the values are potentially quite large. (I think doing this will unblock one of @konradjk's pipelines for now.)