[hail] Fix EXTREME performance regression in column scans.#7771
Merged
danking merged 1 commit intohail-is:masterfrom Dec 20, 2019
Merged
[hail] Fix EXTREME performance regression in column scans.#7771danking merged 1 commit intohail-is:masterfrom
danking merged 1 commit intohail-is:masterfrom
Conversation
They were quadratic. Bad bad bad bad bad. Benchmark now takes ~7s, compared to roughly the amount of time it would take for my laptop to naturally sublimate.
johnc1231
approved these changes
Dec 20, 2019
Contributor
|
Tim for the record I think your joke is really funny |
Contributor
Author
|
hardship brings out the best in us |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They were quadratic. Bad bad bad bad bad.
Benchmark now takes ~7s, compared to roughly the amount of time it
would take for my laptop to naturally sublimate.