Skip to content

[hail] move head/tail from crdd to rvd; fix linear memory usage #7788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 14, 2020

Conversation

tpoterba
Copy link
Contributor

@tpoterba tpoterba commented Jan 2, 2020

Fixes #7765


val newRDD = crdd.mapPartitionsWithIndex({ case (i, it) =>
if (i == idxFirst)
it.drop(nDrop.toInt)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it.drop is going to have issues with region clearing, since by default it's just going to call next() and hasNext() on the iterator.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, good point.

@danking danking merged commit b437273 into hail-is:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix memory usage in ContextRDD.head/tail
3 participants