[hail] Prevent rewriting of TableAggregateByKey after key shortening #7901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-schultz
previously requested changes
Jan 17, 2020
| TableAggregateByKey(child, expr) | ||
|
|
||
| case TableAggregateByKey(TableKeyBy(child, keys, _), expr) if canRepartition => | ||
| case TableAggregateByKey(TableKeyBy(child, keys, false), expr) if canRepartition && ! child.typ.key.startsWith(keys) => |
Member
There was a problem hiding this comment.
If child.typ.key.startsWith(keys), then TableKeyBy will ignore the isSorted flag, so I don't think you want to match on isSorted = false.
Contributor
Author
There was a problem hiding this comment.
I want both. If we're lengthening the key without shuffling, we should not rewrite this as a shuffling aggregation.
Member
There was a problem hiding this comment.
Ah, I get it now. I still think it's clearer matching on TableKeyBy(child, keys, _), since !x.definitelyDoesNotShuffle already implies that x.isSorted = false, but it's not a big deal. Approving.
tpoterba
dismissed
patrick-schultz’s stale review
I think I clarified the code
patrick-schultz
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.