Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] Write custom serializer for ApproxCDFCombiner to avoid issues #7922

Merged
merged 1 commit into from Jan 21, 2020

Conversation

@tpoterba
Copy link
Collaborator

tpoterba commented Jan 19, 2020

No description provided.

Copy link
Collaborator

danking left a comment

@patrick-schultz can you verify that we don't need to serialize some state of java.util.Random and set it on the other side? If that's OK with you, then dismiss my review and approve this PR.

@tpoterba

This comment has been minimized.

Copy link
Collaborator Author

tpoterba commented Jan 21, 2020

from Patrick on zulip:

Sorry, just saw this. Since it's currently nondeterministic anyways, I don't see any problem with just making a new Random on each worker with the default random seed. But I would think there should be a way to just serialize seeds to use to construct new Random instances that would still allow us to make ApproxCDF deterministic using a NonAssociativeCombiner.

@patrick-schultz patrick-schultz dismissed danking’s stale review Jan 21, 2020

I think this is fine for now.

@danking danking merged commit 243920e into hail-is:master Jan 21, 2020
1 check passed
1 check passed
ci-test success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.