Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2d by 1d matmul fix #7986

Merged
merged 2 commits into from Jan 29, 2020
Merged

2d by 1d matmul fix #7986

merged 2 commits into from Jan 29, 2020

Conversation

johnc1231
Copy link
Contributor

I accidentally got the dimensions wrong in one of the matmulShape cases, causing this issue: #7982. This didn't come out in testing because in my 2 dimensional by 1 dimensional ndarray test, I used a square 2 dimensional array, so the shape was the same on either side. This PR adds another test and makes the fix.

@johnc1231
Copy link
Contributor Author

See here: https://docs.scipy.org/doc/numpy/reference/generated/numpy.matmul.html for the semantics that are expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants