Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Matrix Shape Bug #8021

Merged
merged 2 commits into from
Feb 3, 2020

Conversation

johnc1231
Copy link
Contributor

For block matrices, we apparently have a notion of "tensor shape" vs "matrix shape". I am so far not a huge fan of this, as I don't think BlockMatrix was really designed to be anything other than a matrix. Anyway, the bug here is that the types contain the "tensor shape", and the block matrix filtering code was acting under the assumption that the types contained the "matrix shape". I've tried to be explicit when naming them below.

I also added some python tests to catch this. We have Scala filtering tests as well, so just added enough python tests to convince myself this bug was fixed.

@danking danking merged commit de2968e into hail-is:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants