[hail][bugfix] always truncate partitioner keys in TableMultiWayZipJoin#8035
Merged
danking merged 1 commit intohail-is:masterfrom Feb 5, 2020
Merged
[hail][bugfix] always truncate partitioner keys in TableMultiWayZipJoin#8035danking merged 1 commit intohail-is:masterfrom
danking merged 1 commit intohail-is:masterfrom
Conversation
Collaborator
|
Can confirm this fixes my issue |
patrick-schultz
previously requested changes
Feb 5, 2020
| val childRanges = childRVDs.flatMap(_.partitioner.rangeBounds) | ||
| val newPartitioner = RVDPartitioner.generate(childRVDs.head.typ.kType.virtualType, childRanges) | ||
| childRVDs.map(_.repartition(newPartitioner, ctx)) | ||
| childRVDs.map(_.repartition(newPartitioner, ctx).truncateKey(typ.key.length)) |
Member
There was a problem hiding this comment.
Ah, I see the problem. But you're computing a new common partitioner with the wrong key, repartitioning each child RVD, then fixing up the partitioner on each child RVD. Better to just compute the right partitioner before doing the repartitioning. I think this should work:
val childRanges = childRVDs.flatMap(_.partitioner.coarsenedRangeBounds(typ.key.length))
val newPartitioner = RVDPartitioner.generate(typ.kType, childRanges)
childRVDs.map(_.repartition(newPartitioner, ctx))
chrisvittal
force-pushed
the
issue-8027
branch
from
126ff6d to
568ec2e
Compare
chrisvittal
dismissed
patrick-schultz’s stale review
Your fix is better. Applied.
patrick-schultz
approved these changes
Feb 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8027
cc @konradjk