Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] fix import_bgen #8153

Merged
merged 1 commit into from
Feb 25, 2020
Merged

[hail] fix import_bgen #8153

merged 1 commit into from
Feb 25, 2020

Conversation

danking
Copy link
Contributor

@danking danking commented Feb 25, 2020

Scala pattern match is too weak and terrible for this seemingly obvious use-case. (nb: null cannot be used with pattern matching).

Scala pattern match is too weak and terrible for this seemingly obvious use-case.
Copy link
Contributor

@johnc1231 johnc1231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, annoying but necessary

@patrick-schultz
Copy link
Collaborator

annoying but necessary

I mean, you could also fix it to not use nulls, but whatever.

@danking danking merged commit 1820d66 into hail-is:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants