Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail.nd] interoperate with numpy #8198

Merged
merged 2 commits into from Feb 28, 2020

Conversation

danking
Copy link
Collaborator

@danking danking commented Feb 28, 2020

We were missing __rmatmul__.

The treasures you find when cleaning up my shuffler PR 馃し鈥嶁檪 .

We were missing `__rmatmul__`.
Copy link
Contributor

@johnc1231 johnc1231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Had fixing this interop bit on my todo list, didn't realize there was an __rmatmul__ though.

@johnc1231
Copy link
Contributor

You can't compare ndarrays with ==, that does an elementwise thing and produces an ndarray of booleans. Use np.array_equal

@danking
Copy link
Collaborator Author

danking commented Feb 28, 2020

ugh who ever wants that meaning of ==

@danking danking merged commit 12bfa69 into hail-is:master Feb 28, 2020
@akotlar
Copy link
Contributor

akotlar commented Feb 28, 2020

agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants