Skip to content

[query] Fix hl.agg.downsample inside array_agg or group_by #8273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2020
Merged

[query] Fix hl.agg.downsample inside array_agg or group_by #8273

merged 1 commit into from
Mar 10, 2020

Conversation

@tpoterba
Copy link
Contributor

@tpoterba tpoterba commented Mar 9, 2020

copyFrom method was simply wrong. Also needed to fix memory management
in result function.

Fixes #8240

@tpoterba
[query] Fix hl.agg.downsample inside array_agg or group_by
40a4f87 
`copyFrom` method was simply wrong. Also needed to fix memory management
in `result` function.

Fixes hail-is#8240
@danking danking merged commit e1b29f5 into hail-is:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@johnc1231 johnc1231 johnc1231 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@johnc1231 johnc1231

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[query] SIGSEGV from downsample aggregator

3 participants

@tpoterba @johnc1231 @danking