[query] Fix bad error message from mt.make_table() with missing keys
#8275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpoterba
commented
Mar 9, 2020
|
|
||
| col_key_field = list(self.col_key)[0] | ||
| col_keys = [k[col_key_field] for k in self.col_key.collect()] | ||
| col_keys = self.col_key[0].collect() |
Contributor
Author
There was a problem hiding this comment.
simpler and results in less data collected.
patrick-schultz
previously requested changes
Mar 10, 2020
hail/python/hail/matrixtable.py
Outdated
| duplicates = [k for k, count in Counter(col_keys).items() if count > 1] | ||
| if duplicates: | ||
| raise ValueError(f"column keys must be unique, found duplicates: {', '.join(duplicates)}") | ||
| for c in col_keys: |
Member
There was a problem hiding this comment.
You could avoid the second scan by reusing the counter:
counts = Counter(col_keys)
duplicates = [k for k, count in counts.items() if count > 1]
if duplicates:
...
if counts[None] > 0:
...
But if there is more than one missing key, won't this throw the duplicate key error?
patrick-schultz
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8222