Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Throw a validation error for queries that read/write same path #8327

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

tpoterba
Copy link
Contributor

No description provided.

@tpoterba
Copy link
Contributor Author

tpoterba commented Apr 1, 2020

bump on this, but shuffler PR review should be first

@tpoterba
Copy link
Contributor Author

tpoterba commented Apr 7, 2020

bump

Copy link
Contributor

@catoverdrive catoverdrive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

ht = hl.read_table(path)
with pytest.raises(hl.utils.FatalError) as exc:
ht.write(path)
assert "both an input and output source" in str(exc.value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can do something like self.assertRaises(error, "regex match") to bundle that statement together---are we moving away from that sort of assertion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂ we're using pytest now, so pytest is probably preferable to unittest. either one will work though

@danking danking merged commit 49ec05d into hail-is:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants