[query] support emit-level parameters#8371
Conversation
|
The rebase was a little messy. I got it compiling, but there will probably be some minor issues with the tests. It was passing before, so I expect the overall code to be sound. |
|
Looks like some Python failures. It will take me a little while to track them down, but they all look minor and of two forms I understand:
|
chrisvittal
left a comment
There was a problem hiding this comment.
To my eye, this was super clean. A few nits. Substantive parts of the change all look great.
bbadd32 to
a516570
Compare
|
A miracle. It finally passed. That was a real slog. I pushed a bunch of non-trivial changes, so it is probably good if you give a skeptical, fresh look. Summary of new changes:
Let me know if you have any questions. |
|
I've been following along. So I've seen a lot of the new stuff already. I'll take another look. |
chrisvittal
left a comment
There was a problem hiding this comment.
Let's see what shakes out.
It might not look like it, but I promise, I'm trying to keep these as small as possible.
Summary of changes:
apply_method: DependentMethodBuilder, EmitFunctionBuilder analogously. DependentMethodBuilder wraps a MethodBuilder, EmitMethodBuilder wraps a DependentMethodBuilder and an EmitMethodBuilder.Furthermore, this change also adds requiredness to many things and improves ptype interfaces: