Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LiftMeOut bindingEnv in ChildEnvWithoutBindings #8377

Merged
merged 3 commits into from Mar 27, 2020

Conversation

johnc1231
Copy link
Contributor

Fixes #8338

The problem was that in FreeVariables.scala, we call ChildEnvWithoutBindings to create a new env. It's important that the new env we get has the same type of aggregation environments as the baseEnv.

@johnc1231
Copy link
Contributor Author

Added the tests you suggested

@danking danking merged commit 761c774 into hail-is:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[query] inconsistent agg or scan environments
3 participants