Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RVDContext must own partitionRegion or it won't be cleaned up #8412

Merged
merged 2 commits into from
Mar 31, 2020

Conversation

johnc1231
Copy link
Contributor

The biggest headaches always seem to have the smallest code changes to fix.

tpoterba
tpoterba previously approved these changes Mar 31, 2020
Copy link
Contributor

@tpoterba tpoterba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂

@johnc1231 johnc1231 dismissed tpoterba’s stale review March 31, 2020 19:00

Potential for early frees

@johnc1231
Copy link
Contributor Author

Patrick points out this is a problem, since freshContext passes the partitionRegion along to a new RVDContext, which will also own it.

@danking danking merged commit 50b0a9c into hail-is:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants