[hail] fix binom_test, improve docs, improve testing #8420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - correct the interpretation of less and greater. - improve the formatting and verbiage of the docs, - expand upon the statistical definition alluded to previously in only the less case, - add python tests which would have caught this error, - add python tests which test against `scipy`, - deprecate the use of `'two.sided'`, an R-ism, document the preferred use of `'two-sided'`, a Python-ism, and - fix an error message in Scala that used yet another naming of the tow sided test.
Contributor
|
Fixes #8419 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
case,
scipy,'two.sided', an R-ism, document the preferred use of'two-sided', a Python-ism, and