Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] fix binom_test, improve docs, improve testing #8420

Merged
merged 5 commits into from
Apr 1, 2020

Conversation

danking
Copy link
Contributor

@danking danking commented Apr 1, 2020

Changes:

  • correct the interpretation of less and greater.
  • improve the formatting and verbiage of the docs,
  • expand upon the statistical definition alluded to previously in only the less
    case,
  • add python tests which would have caught this error,
  • add python tests which test against scipy,
  • deprecate the use of 'two.sided', an R-ism, document the preferred use of
    'two-sided', a Python-ism, and
  • fix an error message in Scala that used yet another naming of the two sided test.

Changes:
- correct the interpretation of less and greater.
- improve the formatting and verbiage of the docs,
- expand upon the statistical definition alluded to previously in only the less
  case,
- add python tests which would have caught this error,
- add python tests which test against `scipy`,
- deprecate the use of `'two.sided'`, an R-ism, document the preferred use of
  `'two-sided'`, a Python-ism, and
- fix an error message in Scala that used yet another naming of the tow sided test.
@johnc1231
Copy link
Contributor

Fixes #8419

Copy link
Contributor

@johnc1231 johnc1231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dan

@danking danking merged commit d9c5629 into hail-is:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants