Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Fix dosage length check. #8487

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

chrisvittal
Copy link
Collaborator

This illustrates one of the footguns in using CodeBuilder. When using
functionality like ifx, we must be sure to actually put the resultant
code on the CodeBuilder in the block we pass to ifx. Otherwise we won't
add any code and the behavior may be surprising.

This is basically equivalent to storing some Code in a variable and then
never passing that variable into a returned Code, so it is never
executed.

This illustrates one of the footguns in using CodeBuilder. When using
functionality like ifx, we must be sure to actually put the resultant
code on the CodeBuilder in the block we pass to ifx. Otherwise we won't
add any code and the behavior may be surprising.

This is basically equivalent to storing some Code in a variable and then
never passing that variable into a returned Code, so it is never
executed.
chrisvittal added a commit to chrisvittal/hail that referenced this pull request Apr 7, 2020
This is the same issue as hail-is#8487. Not actually generating the error
throwing code.
@chrisvittal chrisvittal assigned catoverdrive and unassigned akotlar Apr 7, 2020
@chrisvittal
Copy link
Collaborator Author

Alex is out. PR is tiny. Reassigning.

@akotlar
Copy link
Contributor

akotlar commented Apr 7, 2020

chris don't I got it

@danking danking merged commit 7485fdb into hail-is:master Apr 7, 2020
danking pushed a commit to danking/hail that referenced this pull request Apr 8, 2020
This illustrates one of the footguns in using CodeBuilder. When using
functionality like ifx, we must be sure to actually put the resultant
code on the CodeBuilder in the block we pass to ifx. Otherwise we won't
add any code and the behavior may be surprising.

This is basically equivalent to storing some Code in a variable and then
never passing that variable into a returned Code, so it is never
executed.
chrisvittal added a commit to chrisvittal/hail that referenced this pull request Apr 8, 2020
This is the same issue as hail-is#8487. Not actually generating the error
throwing code.
danking added a commit that referenced this pull request Apr 8, 2020
* [query] Fix CallStats fatal assertion

This is the same issue as #8487. Not actually generating the error
throwing code.

* bump

Co-authored-by: Daniel King <dking@broadinstitute.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants