Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] fix incorrect method lookup #8537

Merged
merged 3 commits into from Apr 13, 2020
Merged

[query] fix incorrect method lookup #8537

merged 3 commits into from Apr 13, 2020

Conversation

cseed
Copy link
Collaborator

@cseed cseed commented Apr 12, 2020

Plus:

  • Boolean ldc (load constant) instructions need an int, not a boolean. JVM seems OK with it, but the asm bytecode verifier rejects it.
  • In Apply codegen, the zip in function lookup was potentially truncating the arguments, selecting an incorrect function. Fix, and simplify the definition of methods.
  • Fix/simplify asm error reporting from asm in lir Emit. The old code was crashing inside asm. I used the new code to debug some bytecode issues, it works well.
  • compute max locals/stack, needed by the asm verifier (CheckClass).

@konradjk This fixes your class not found issue.

catoverdrive
catoverdrive previously approved these changes Apr 12, 2020
@catoverdrive
Copy link
Contributor

@cseed it looks like tests are failing with I == Z. Is there another place you need to carry through the Boolean as Int thing?

Copy link
Contributor

@catoverdrive catoverdrive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(back to you)

necessary since booleans are represented by ints
@cseed
Copy link
Collaborator Author

cseed commented Apr 12, 2020

I had to add a TypeInfo[_] to LdcX because inference from the value doesn't work anymore when we replace the boolean with an int. Passing now.

@cseed cseed dismissed catoverdrive’s stale review April 12, 2020 10:20

fixed failing tests

@danking danking merged commit d32983a into hail-is:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants