[query] fix linreg aggregator correctness bug #8575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpoterba
previously requested changes
Apr 17, 2020
Contributor
tpoterba
left a comment
tpoterba
left a comment
There was a problem hiding this comment.
need a test, however weird+hard to reproduce this bug is.
Member
Author
|
It uses |
Contributor
|
Yeah, a test of linreg is what I meant, thanks. |
tpoterba
approved these changes
Apr 17, 2020
patrick-schultz
force-pushed
the
linreg-agg-bugfix
branch
from
ac1d5ce to
8adbff9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8349.
The
anyMissingimplementation onPArraywas wrong, and could return false if the only missing elements were in the last aligned 32 bits containing the end of the missing bits. This in turn let some rows be included in the regression even if some of the covariates were missing.