Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] fix linreg aggregator correctness bug #8575

merged 3 commits into from Apr 21, 2020


Copy link

Fixes #8349.

The anyMissing implementation on PArray was wrong, and could return false if the only missing elements were in the last aligned 32 bits containing the end of the missing bits. This in turn let some rows be included in the regression even if some of the covariates were missing.

Copy link

@tpoterba tpoterba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a test, however weird+hard to reproduce this bug is.

Copy link
Collaborator Author

It uses hasMissingValues now, which already has a test. I'm beefing up that test now to be safe. test_linreg fails if you swap the intercept with the other covariate, I can add that too.

Copy link

Yeah, a test of linreg is what I meant, thanks.

@danking danking merged commit fa1bc6f into hail-is:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

error in linreg aggregator based on placement of '1'
3 participants