[query] Rewrite ExportEntriesByCol to stage locally#8613
Merged
danking merged 2 commits intohail-is:masterfrom Apr 26, 2020
Merged
[query] Rewrite ExportEntriesByCol to stage locally#8613danking merged 2 commits intohail-is:masterfrom
danking merged 2 commits intohail-is:masterfrom
Conversation
konradjk
approved these changes
Apr 23, 2020
Collaborator
konradjk
left a comment
konradjk
left a comment
There was a problem hiding this comment.
Works perfectly!!! My understanding of the Scala is rudimentary, but it all seems sensible, and is passing our real-world test.
akotlar
reviewed
Apr 23, 2020
| new OutputStreamWriter(bcFS.value.create(partFolder + "/" + j.toString + extension), "UTF-8") | ||
| val filePaths = Array.tabulate(endIdx - startIdx) { j => | ||
| val finalPath = partFolder + "/" + j.toString + extension | ||
| val tempPath = bcFS.value.getTemporaryFile("file:///tmp", suffix=Some(extension)) |
Contributor
There was a problem hiding this comment.
this is going to conflict with cotton's fs change I believe, will need to be extension=
Contributor
There was a problem hiding this comment.
Actually, now it will be createTmpPath, which lives on ExecuteContext
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
will tag this as WIP, will be easier for me to rebase than him.
Contributor
Author
There was a problem hiding this comment.
thanks for the heads up
tpoterba
force-pushed
the
eebc-stage-locally
branch
from
e816620 to
3beb5df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.