[hail] fix constant pool issue #8622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cseed
previously requested changes
Apr 23, 2020
cseed
previously requested changes
Apr 23, 2020
| class LdcX(val a: Any, val ti: TypeInfo[_]) extends ValueX { | ||
| assert( | ||
| a.isInstanceOf[String] || a.isInstanceOf[Double] || a.isInstanceOf[Float] || a.isInstanceOf[Int] || a.isInstanceOf[Long], | ||
| s"not a string, double, float, int, or long: {a}") |
There was a problem hiding this comment.
Haha, not an f-string. In Scala, you need $a.
|
FWIW this replaced my issue with another one (that I was able to fix in my code), so I'm unblocked but also can't speak to pros or cons on this one |
cseed
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constant pool may only hold references to JVM things (e.g. a class),
Strings, Floats, Doubles, Ints, and Longs. https://docs.oracle.com/javase/specs/jvms/se7/html/jvms-5.html