[query] Fix bad tuple indexing on PCanonicalBaseStructSettable#8799
Merged
danking merged 9 commits intohail-is:masterfrom May 15, 2020
Merged
[query] Fix bad tuple indexing on PCanonicalBaseStructSettable#8799danking merged 9 commits intohail-is:masterfrom
danking merged 9 commits intohail-is:masterfrom
Conversation
tpoterba
previously requested changes
May 14, 2020
|
|
||
| def loadField(cb: EmitCodeBuilder, fieldIdx: Int): IEmitCode = { | ||
| def loadField(cb: EmitCodeBuilder, i: Int): IEmitCode = { | ||
| val ptTuple = pt.asInstanceOf[PTuple] |
Contributor
There was a problem hiding this comment.
I think this is the wrong fix. PCBaseStructSettable doesn't seem broken -- the fieldIdx here should just be base struct index, not tuple index.
The fix should be to use the true index here:
Looks like Chris's PR that moved a bunch of Emit to IEmit broke this on 4/22.
Contributor
Author
There was a problem hiding this comment.
Ah, ok that's a better idea. One sec
Contributor
Author
|
Fixed! Thanks. |
tpoterba
approved these changes
May 14, 2020
Contributor
Author
|
Added WIP because about to push fixes that still have some debugging info floating around |
Merged
This was referenced Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix Julia's bug here: https://discuss.hail.is/t/arrayindexoutofboundsexception-error-in-hail-0-2-40/1413/11
I will make a follow up PR tomorrow splitting things up and making a
PCanonicalTupleCode. I just wanted to get rid of this blatantly wrong thing.