Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[site] add documentation search bar, search page #8955

Merged
merged 16 commits into from Jun 17, 2020

Conversation

akotlar
Copy link
Contributor

@akotlar akotlar commented Jun 13, 2020

cc @mkveerapen @tpoterba

  1. Adds natural language documentation search bar with autocompletion
  2. Adds paginated search page to browse all search results
  3. Makes navbar scripts async, to allow inclusion of navbar scripts at top of file without impacting performance (since we include the navbar.html content in other templates we cannot easily locate those scripts at bottom of the includers' pages)
  4. Increases hero content width on mobile.
  5. Hides sphinx search bar

http://34.207.246.132/

@@ -66,19 +68,20 @@
</ul>
</div>
<script>
<xsl:text disable-output-escaping="yes" >
<xsl:text disable-output-escaping="yes" async="true">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean for an xsl:text to be async?

@akotlar
Copy link
Contributor Author

akotlar commented Jun 17, 2020

bump

@danking danking merged commit 8ec104b into hail-is:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants