Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query][bugfix] clear region in rvd.countPerPartition #9009

Merged
merged 6 commits into from Jun 23, 2020

Conversation

catoverdrive
Copy link
Contributor

@catoverdrive catoverdrive commented Jun 23, 2020

No description provided.

Copy link
Contributor

@johnc1231 johnc1231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe the right way to do this is to put a boundary in between crdd and cmapPartitions. That way we aren't clearing a region that we didn't create.

@johnc1231 johnc1231 mentioned this pull request Jun 23, 2020
Copy link
Collaborator

@danking danking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a test that triggers this memory overflow. Maybe a one partition range table that allocates a huge struct on each row and is the converted to a block matrix?

@catoverdrive catoverdrive dismissed stale reviews from danking and johnc1231 June 23, 2020 20:50

addressed

@danking danking merged commit 1c64b0e into hail-is:master Jun 23, 2020
@julirsch
Copy link

Wow. This will make things so much cheaper!

@johnc1231
Copy link
Contributor

Yeah I can't believe we didn't notice this sooner, should help a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants