[query][bugfix] clear region in rvd.countPerPartition #9009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnc1231
previously requested changes
Jun 23, 2020
Contributor
johnc1231
left a comment
johnc1231
left a comment
There was a problem hiding this comment.
I think maybe the right way to do this is to put a boundary in between crdd and cmapPartitions. That way we aren't clearing a region that we didn't create.
Merged
danking
previously requested changes
Jun 23, 2020
Contributor
danking
left a comment
danking
left a comment
There was a problem hiding this comment.
We need a test that triggers this memory overflow. Maybe a one partition range table that allocates a huge struct on each row and is the converted to a block matrix?
added 2 commits
June 23, 2020 16:37
added 3 commits
June 23, 2020 16:56
johnc1231
approved these changes
Jun 23, 2020
|
Wow. This will make things so much cheaper! |
Contributor
|
Yeah I can't believe we didn't notice this sooner, should help a lot. |
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.