[hail] NDArray eye #9105
[hail] NDArray eye #9105
Conversation
There was a problem hiding this comment.
The word "identity" is not present anywhere in the description as far as I can tell. I would include that somewhere for searchability purposes. Or we could just also add the identity function which is basically the same as eye but has a more discoverable name. identity would just be implemented by calling eye. https://numpy.org/doc/stable/reference/generated/numpy.identity.html#numpy.identity
|
Good point John. I had omitted "identity" since we didn't have an identity function, but it's worth adding, would help our new docsearch. If you're back, I can assign you instead. |
|
I'm back, feel free to assign me to some of these ndarray things. (Also let me know issues you run into when adding stuff) |
|
Rather than linking out to Numpy, I added an identity function. In a followup PR I will add the "k" argument to |
hail/python/hail/nd/nd.py
Outdated
|
|
||
| Examples | ||
| -------- | ||
| >>> hl.eval(hl.nd.eye(2, dtype=hl.tint32)) |
There was a problem hiding this comment.
I think this should have one example where you pass M, otherwise I think we are good to merge.
* ndarray eye * fix * unnecessary cast * add identity * doc M
* ndarray eye * fix * unnecessary cast * add identity * doc M
Identity matrix, needed for ridge regression in Hail. This is obviously suboptimal, it should be a special instance of a sparse ndarray that specifies 'k', but this matches the Numpy implementation and represents a good start.