Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: Fix bug that prevented concatenating ndarrays that are fields of a table #9161

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

johnc1231
Copy link
Contributor

CHANGELOG: Fix bug that prevented concatenating ndarrays that are fields of a table

Two bugs:

  1. We can't call .typ on concat_ir, since that kicks off the type inference process before this IR gets wrapped in a TableIR that provides the necessary context to infer the type.
  2. We need to _compute_type on self.nds as a whole, not just each of its args.

@akotlar
Copy link
Contributor

akotlar commented Jul 28, 2020

Thanks John!

@danking danking merged commit e459c3c into hail-is:master Jul 28, 2020
annamiraotoole pushed a commit to annamiraotoole/hail that referenced this pull request Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants