Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[batch] add google-cloud-storage dep #9172

Merged
merged 1 commit into from Jul 29, 2020

Conversation

akotlar
Copy link
Contributor

@akotlar akotlar commented Jul 29, 2020

CHANGELOG: fix missing google-cloud-storage python dependency, required by batch.

This makes the tutorial work: https://hail.is/docs/batch/getting_started.html

Version chosen based on our dataproc dependency declaration in init_notebook.py. Note that 1.25.* will install a new version of google-auth. On that note, it is possible that we can upgrade /auth to use a newer google-auth (@danking), as the issue listed in the /auth docker file (googleapis/google-auth-library-python#443) is obviated by the 1.11.2 release: googleapis/google-auth-library-python#446.

Copy link
Collaborator

@danking danking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find

@danking
Copy link
Collaborator

danking commented Jul 29, 2020

Also happy to accept a PR updating the auth Dockerfile

@danking danking merged commit ab5fa92 into hail-is:master Jul 29, 2020
annamiraotoole pushed a commit to annamiraotoole/hail that referenced this pull request Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants