Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hailctl dataproc] Replace deprecated gcloud arguments in hailctl dataproc start and modify #9250

Merged
merged 2 commits into from Aug 14, 2020

Conversation

nawatts
Copy link
Contributor

@nawatts nawatts commented Aug 11, 2020

gcloud 284.0.0 deprecated the --num-preemptible-workers and --preemptible-worker-boot-disk-size arguments to gcloud dataproc clusters create.

gcloud 285.0.0 deprecated the --num-preemptible-workers argument to gcloud dataproc clusters update.

This replaces --num-preemptible-workers with --num-secondary-workers and --preemptible-worker-boot-disk-size with --secondary-worker-boot-disk-size in calls to gcloud from hailctl dataproc start and hailctl dataproc modify.

Since the new arguments were added in gcloud version 285.0.0 (released in March 2020), this also adds a requirement that gcloud be at least version 285.0.0. Alternatively, the arguments could be switched based on the gcloud version.

Copy link
Contributor

@danking danking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome. In the future, if you assign this PR to someone we'll probably look at it sooner. We have a random person picker at https://scorecard.hail.is. "Compilers Team" owns hailctl dataproc.

@danking danking self-assigned this Aug 13, 2020
@nawatts
Copy link
Contributor Author

nawatts commented Aug 13, 2020

Thanks. Didn't know what the protocol was and didn't want to be pushy.

@danking
Copy link
Contributor

danking commented Aug 13, 2020

We respond well to pushy 😉

@danking danking merged commit 398ab58 into hail-is:main Aug 14, 2020
@nawatts nawatts deleted the hailctl-dataproc-deprecated-gcloud-args branch August 16, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants