Add BlockMatrixFilterRowsRDD to decrease transposing#9373
Merged
danking merged 3 commits intoAug 31, 2020
Conversation
Contributor
Author
johnc1231
force-pushed
the
johnc-block-matrix-filter-rows-no-transpose
branch
from
2735c64 to
f418b68
Compare
tpoterba
approved these changes
Aug 31, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
filter_rowsis implemented as a transpose. Nik and Konrad are running into driver memory issues when doingtree_matmul, and one theory of mine is that making lots ofBlockMatrixTransposeRDD's is contributing to this. I'd like to make this change to avoid that in the future.