Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ArrayExpression's head method #9482

Merged
merged 1 commit into from Sep 18, 2020

Conversation

nawatts
Copy link
Contributor

@nawatts nawatts commented Sep 18, 2020

Follow up to #9474.

johnc1231
johnc1231 previously approved these changes Sep 18, 2020
@johnc1231
Copy link
Contributor

This looks fine, but I need to confirm we don't use head in any other code before approving

@nawatts
Copy link
Contributor Author

nawatts commented Sep 18, 2020

Admittedly, I did not do a thorough search, but this was the only git grep '\.head(' result that looked like ArrayExpression head instead of Table/MatrixTable head.

Copy link
Contributor

@johnc1231 johnc1231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is the only usage, thanks!

@danking danking merged commit c898030 into hail-is:main Sep 18, 2020
@nawatts nawatts deleted the deprecate-array-head branch May 6, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants