[query] add hailctl function to set global flags #9506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danking
reviewed
Sep 25, 2020
| assert n == 17 | ||
| EOF | ||
| HAIL_BILLING_PROJECT=test HAIL_DONT_RETRY_500=1 HAIL_QUERY_BACKEND=service python3 test.py | ||
| HAIL_BILLING_PROJECT=test HAIL_DONT_RETRY_500=1 HAIL_QUERY_BACKEND=service python3 -m pytest --log-cli-level=INFO -s -vv --instafail --durations=50 /io/test/ |
Contributor
There was a problem hiding this comment.
I think you forgot to check in the test file
added 2 commits
September 30, 2020 15:21
danking
pushed a commit
to danking/hail
that referenced
this pull request
Oct 1, 2020
This reverts commit 06b5a9a.
danking
added a commit
that referenced
this pull request
Oct 1, 2020
danking
pushed a commit
to danking/hail
that referenced
this pull request
Oct 1, 2020
* [query] add hailctl function to set global flags * fix * actually check in test file * fix checks * actually fix check * more fixes * gotta run query tests with dev account because flags are dev-only * add to billing project, fix * fix test
danking
added a commit
that referenced
this pull request
Oct 1, 2020
* [query] add hailctl function to set global flags (#9506) * [query] add hailctl function to set global flags * fix * actually check in test file * fix checks * actually fix check * more fixes * gotta run query tests with dev account because flags are dev-only * add to billing project, fix * fix test * use a sql migration Co-authored-by: Arcturus Wang <wang@broadinstitute.org>
danking
pushed a commit
to danking/hail
that referenced
this pull request
Oct 7, 2020
This was missing in hail-is#9532 / hail-is#9506
danking
added a commit
that referenced
this pull request
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted a quick way to set global feature flags on the service backend. Also took the opportunity to move query tests into their own file.