Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Add ignore_in_sample_allele_frequency flag to hl.de_novo #9549

Merged
merged 2 commits into from
Oct 5, 2020

Conversation

tpoterba
Copy link
Contributor

@tpoterba tpoterba commented Oct 2, 2020

Also take the opportunity to implement the check on pop_frequency_prior
in accordance with our years-old comment.

Also take the opportunity to implement the check on pop_frequency_prior
in accordance with our years-old comment.
@tpoterba
Copy link
Contributor Author

tpoterba commented Oct 2, 2020

@johnc1231
Copy link
Contributor

Failing a local backend test

@tpoterba
Copy link
Contributor Author

tpoterba commented Oct 5, 2020

fixed the local backend test (had to do with the HailUserException not getting extracted properly in lowered execution, which I'm punting on right now).

Docs build is now failing, which I think is a problem in main.

@johnc1231
Copy link
Contributor

Ah, sorry about that. I'll fix the HailUserException thing on local backend in a separate PR.

Copy link
Contributor

@johnc1231 johnc1231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, meant to approve when I commented earlier this morning

@danking danking merged commit 27bf7ee into hail-is:main Oct 5, 2020
@johnc1231
Copy link
Contributor

#9569 Fixes the HailUserException error you encountered. LocalBackend now correctly handles HailUserExceptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants