[query] Add ignore_in_sample_allele_frequency flag to hl.de_novo#9549
Merged
danking merged 2 commits intohail-is:mainfrom Oct 5, 2020
Merged
[query] Add ignore_in_sample_allele_frequency flag to hl.de_novo#9549danking merged 2 commits intohail-is:mainfrom
ignore_in_sample_allele_frequency flag to hl.de_novo#9549danking merged 2 commits intohail-is:mainfrom
Conversation
Also take the opportunity to implement the check on pop_frequency_prior in accordance with our years-old comment.
tpoterba
force-pushed
the
de-novo-option
branch
from
41bbf4c to
33ec5b8
Compare
Contributor
Author
Contributor
|
Failing a local backend test |
Contributor
Author
|
fixed the local backend test (had to do with the HailUserException not getting extracted properly in lowered execution, which I'm punting on right now). Docs build is now failing, which I think is a problem in main. |
Contributor
|
Ah, sorry about that. I'll fix the |
johnc1231
approved these changes
Oct 5, 2020
Contributor
johnc1231
left a comment
johnc1231
left a comment
There was a problem hiding this comment.
Sorry, meant to approve when I commented earlier this morning
Contributor
|
#9569 Fixes the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also take the opportunity to implement the check on pop_frequency_prior
in accordance with our years-old comment.