Skip to content

[hailctl dataproc] Print all gcloud args in hailctl dataproc modify#9609

Merged
danking merged 1 commit intohail-is:mainfrom
nawatts:hailctl-dataproc-modify-print-gcloud-command
Oct 19, 2020
Merged

[hailctl dataproc] Print all gcloud args in hailctl dataproc modify#9609
danking merged 1 commit intohail-is:mainfrom
nawatts:hailctl-dataproc-modify-print-gcloud-command

Conversation

@nawatts
Copy link
Copy Markdown
Contributor

@nawatts nawatts commented Oct 19, 2020

Currently, the hailctl dataproc modify does not print the first (after the cluster name) argument to gcloud dataproc clusters update. This bug was introduced in #9078.

For example:

$ hailctl dataproc modify some-cluster --num-workers 2 --dry-run
gcloud dataproc clusters update some-cluster \

With this change, the --num-workers argument is printed.

$ hailctl dataproc modify some-cluster --num-workers 2 --dry-run
gcloud dataproc clusters update some-cluster \
    --num-workers=2

@johnc1231 johnc1231 self-assigned this Oct 19, 2020
@danking danking merged commit 425e779 into hail-is:main Oct 19, 2020
@nawatts nawatts deleted the hailctl-dataproc-modify-print-gcloud-command branch May 6, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants