Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hail] include the diagonal in PCRelate #9816

Merged
merged 2 commits into from Dec 15, 2020
Merged

Conversation

danking
Copy link
Collaborator

@danking danking commented Dec 10, 2020

CHANGELOG: hl.pc_relate now includes values on the diagonal of kinship, IBD-0, IBD-1, and IBD-2

@tpoterba
Copy link
Contributor

how would this work with maximal_independent_set?

CHANGELOG: `hl.pc_relate` now includes values on the diagonal of kinship, IBD-0, IBD-1, and IBD-2
@danking
Copy link
Collaborator Author

danking commented Dec 10, 2020

Ugh. I added a keyword parameter that defaults to the old behavior.

@tpoterba
Copy link
Contributor

Yeah, annoying. We should probably be boxing this up so that most users never actually use maximal_independent_set but just prune_related_samples(mt, ...) and we can do what we want in there.

@tpoterba
Copy link
Contributor

Hail is 1-2 levels of abstraction too low for most users

@danking
Copy link
Collaborator Author

danking commented Dec 10, 2020

One of us should do one boring genetics project with someone and just publish whatever we write during that process.

@danking
Copy link
Collaborator Author

danking commented Dec 15, 2020

bump @chrisvittal

@danking danking merged commit 25e5e5b into hail-is:main Dec 15, 2020
@olavurmortensen
Copy link

Awesome, thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants